The following bugs have been fixed:
- Spell checking was not on by default when composing a comment.
- When pasting from another source, script tags were included.
- The last four characters were intermittently omitted when posting (this one is a hopeful, as I've never been able to reproduce the problem).
- The author rating filter's current setting was not saved across browser sessions.
27 comments:
Any news on the panel reconstruction situation reported on 1.06?
yagij,
After rereading your original comment on this, I was less clear on the real issue you're raising.
If it's that the panel appears and disappears, causing the page to rewrap, that can't be helped. It is in fact a feature (you'd want other sites to have the entire screen).
If it's that the panel comes up slowly, I mentioned one slight workaround that could help, but haven't yet implemented it. I should point out that this will not help when switching between multiple CR comments pages.
Finally, there is the issue that the CR Companion panel appears outside the combined rectangle of the tabs bar and the current page. This means that the tabs move around when switching back and forth. I find this annoying, and have looked at changing it. Unfortunately, the designers of Firefox didn't leave a good hook for doing this. But where there's a will, there's a way...
Ken,
As of today Google toolbar loses its search bar and most icons when cr companion is enabled. It affects the current Google toolbar release (3.0.1.20081127w) on firefox 3.0.5 under XP, with the 1.07 release of cr companion. The Google toolbar beta 5.x is even worse, with just a blank toolbar showing. This is new behavior today. XP just pushed an update this morning, but I'm not sure when the behavior started. Disabling cr companion restores the toolbar.
More on the Panel question later, but I have 2 questions:
1) [Feature Request] Can you enable shortcuts like ctrl-b, ctrl-i to bold and italicize? Can we get an underline feature/button?
2) [Function/Bug] When I use the Reply button, it always seems to duplicate the Holoscan time stamp. Function or Bug?
e.g.
Eric | 01.15.09 - 10:38 am | #
Eric | 01.15.09 - 10:38 am | #
Jay, thanks for the report. I don't use the google toolbar, so haven't seen this. I'll take a look. BTW, did this start happening between 1.06 and 1.07?
yagij, I'll take a look at what's involved for shortcuts. Underline isn't supported by haloscan, so that's a no go.
As for duplicate timestamps, are you selecting the timestamp yourself? CRC pastes in the combination of what was selected and the timestamp.
Ken,
I am wondering if you implemented your paste function similar to TinyMCE or FCKeditor? I have observed that starting with 1.07, linefeeds in certain situations get suppressed from pastes that aren't from a MSWord source. The editor window still reflects the linefeed but the actual Haloscan post doesn't have it.
A sample of that effect is this post:
http://www.ft.com/cms/s/0/47e6788c-e274-11dd-b1dd-0000779fd2ac.html?nclick_check=1
Are you trying to intelligently detect the difference? I know that the TinyMCE people found that difficult which is why they implemented the two button solution.
I doubt that it was specific to the 1.06 to 1.07 changes. I don't think I was getting automatic updates for your experimental code. I believe the add-ons window was showing 1.01 when I noticed the problem, and I updated then to find out if it was a current problem. I doubt that it was specific to the 1.06 to 1.07 changes. I don't think I was getting automatic updates for your experimental code. I believe the add-ons window was showing 1.01 when I noticed the problem, and I updated then to find out if it was a current problem.
In fact, I just stepped out and installed 1.01 and am experiencing the same problem. Whatever it is, it isn't because of your new code.
RE, I had been wondering why they added that button. Good point. And yes, I've been filtering Word gunk indiscriminately, which may explain the problem. Paste is turning into a major time sink - there's always at least one of these...
Jay, I just reproduced the problem. I'm guessing it's a clash in our overlays. I've been hoping to come up with a better layout anyway (I would prefer the CR panel to have the tabs above it, rather than to its left). I'll see if I can solve two problems in one blow.
Ken,
More symptoms, when your code is enabled, all of the add-on icons in the customize toolbar window disappear, including fox clocks and sage-too.
Thanks, Jay. Good info.
"As for duplicate timestamps, are you selecting the timestamp yourself? CRC pastes in the combination of what was selected and the timestamp."
When it happens to me, the first line's "#" seems to be a URL to the cited/quoted comment and the second line is regular text. Which one of those lines would be the CRC timestamp?
yagij,
The one without the URL on the '#'.
I do this to avoid adding distracting markup to the quote.
Jay, I found the culprit, thanks for your help. I'll include the fix in the next rev.
The one without the URL on the '#'.
-----
I don't know how it didn't occur to me, but now that I know how CRC is designed to work, I have had little/no problem using it.
At first, I thought you were ingeniously adding a URL to the pasted selection. Definitely a 'Problem Between Keyboard & Chair' moment for me...
Thanks again for your work, Ken.
I look forward to the possibilities of shortcuts, and maybe return to the panel reconstruction situation later.
(Side Note: I just find it odd that the screen is assembled fine, but when I click back to it from another tab, it is like the webpage is loading for the first time. You would think FF would preserve the output...)
The problem is I can't determine whether to show the CR sidebar until after the page is visible, so Firefox first displays the page, then the sidebar becomes visible, and Firefox has to lay the page out again in response to a size change.
If I could determine the change before the page became visible, it would improve the situation. I haven't revisited this since I first wrote the code, but at the time I don't remember finding an appropriate hook. I've experienced enough pain working around some of Firefox's missing events as it is...
Another question: Using your own development boxes for the following URL, how responsive is CRC for you?
http://www.haloscan.com/comments/calculatedrisk/7166128661846746703/
I ask because it is completely locking down my iBook G4 (Tech Details can be provided) to the point that I find myself setting the refresh rate higher and higher because it is pegging FF @ 50-100% on each subsequent refresh.
yagij,
My machine is still responsive, but it's a development class box.
I spent some time awhile back optimizing, after experiencing tanta's eulogy thread. I don't know that I can squeeze much more out.
The big issue is that there is no haloscan support to ask for just new comments. CRC has to parse the entire file, and then scan it, each time it does an update.
In anticipation of the move to the new commenting system, I've asked the JS-Kit guys for this support. No response from them yet though; we'll see.
Another thought occurs to me: I have been seeing a problem in 1.07 that seems to be affecting CPU usage (and causing other problems). You could try backing out to 1.06, and see if that helps. If so, please let me know.
Just fyi, I'm having similar speed issues with CR Companion (high load, browser unresponsive, 5 second delays on "page down," etc) with CR 1.07. I downgraded to 1.06 and the problem remains. It slows down all my tabs, making the browser unusable. Even while typing this comment, it's been pausing for several seconds (I have two haloscan / CR tabs open at the moment, about 200-400 comments each) every few words.
Actually it hung altogether. I saved the above text using a copy and paste from Firefox to IE, because I was unable to type anything at all. Firefox became completely unresponsive and kept popping up a window titled "Warning: Unresponsive script" and asking if I wanted to stop the script croverlay.js:1077 (this is version 1.06). Unfortunately, it didn't seem to matter if I said "Stop script" or "Continue," either way the browser was hung. After ten minutes I was able to close one of the haloscan tabs and copy this text. Firefox is still mostly unresponsive and still asking me repeatedly if I want to stop that script.
This may or may not be related, but with either version, the comments and the displayed list of authors do not change when I either change the filtering level, or change the rating of an author. I have to reload for the filtering change to take effect.
This is a single-core 2.4GHz/1GB Windows 2000 box with Firefox 3.0.5, Download Statusbar 0.9.6.0, DownloadHelper 4.0.1, NoScript 1.8.9.2, and Old Location Bar 1.3.
Like Jay, I also noticed that any customizations I make to the toolbar (or whatever they currently call the row of buttons that normally have the Back, Forward, Refresh, Reload, etc icons) all vanish when CR Companion is loaded. I'm not sure if this is the exact same issue Jay reported; I merely changed the "Home" button into a "Print" button, and CR Companion changes it back.
Thanks for your efforts, the utility is a big help when it works. :-)
Kevin,
Thanks for the report. Sounds like a configuration I haven't been running is causing some serious problems. Do you by any chance have google toolbar installed?
No, I do not have Google Toolbar installed. I went back to CR Companion 1.07 and disabled the DownloadHelper, Download Statusbar, and Old Location Bar extensions, but got the same behavior.
OK, I disabled NoScript and now CR Companion is the only extension enabled. It's still behaving the same. Further, I'm unable to change the rating of any author. I can choose the rating level (say, "Good") but the author's name does not move from the "Unrated" category in the right sidebar, nor does it change the "(Unrated)" in the main comment window.
Kevin, has CR Companion worked for you in the past? If so, when did this behavior appear?
Hi Ken, yes it did work in the past. Unfortunately I do not remember when these problems appeared. I uninstalled it several weeks ago because I suspected it of slowing down my browser, and recently decided to give it another try and noticed the other problems. I've uninstalled it again and my browser (with all the other plug-ins re-enabled) is speedy again. Sorry I can't be more precise than that. At this point it probably makes sense for me just to wait until CR transitions to JS-Kit and then try it again. Although I'd be happy to run any specific tests that might be helpful to you.
Thanks for the offer, Kevin. I may try sending you a specific version to try. Do you mind sending me an email so I have your address?
I've sent you an email.
Gentle nudge to release the fixed version for the google toolbar.
JP, gotcha. Hopefully later today.
Post a Comment